fix: handle service name on multi-lines (strings with '+' operator)#202
Open
ludosch wants to merge 1 commit intoember-codemods:masterfrom
Open
fix: handle service name on multi-lines (strings with '+' operator)#202ludosch wants to merge 1 commit intoember-codemods:masterfrom
ludosch wants to merge 1 commit intoember-codemods:masterfrom
Conversation
rwjblue
requested changes
Feb 6, 2020
Member
rwjblue
left a comment
There was a problem hiding this comment.
I'm not sure that we should flatten things here (vs preserving the concatenation).
Happy to land either way (though I'd love to discuss the pros/cons of flattening), but will need some tests in order to move forward.
508179e to
f32f5dd
Compare
Author
|
@rwjblue : I added tests. |
Author
|
@rwjblue : do you finally want a new version without flattening the names anyway ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got error on test file :
Reproduction
In test file, you have an inject service name cuted like this :
And run ember-qunit-codemod (no special arguments)
Change
This PR transforms cuted long services names in a single one, so there are no longer errors